This repository was archived by the owner on Feb 10, 2025. It is now read-only.
models: Add a seperate models-staging.yml to allow for separate versioning. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versioning. It has been challening to ensure that changes get deployed correctly in staging because it requires a number of extra steps around tagging, publishing and updating the `models.yml` file. The majority of this pain comes from the fact that we were sharing the `models.yml` file between production and other environments and therefore couldn't relax our versioning between envrionments. This change copies the existing `models.yml` file to `models-staging.yml` and changes all of the model/connector image URLs to point at the `master` tag rather than a more specific version tag. It also adds a switch where this file is loaded by the app to load the correct version based on the environment. The downside to this approach is that there will be extra effort and attention needed to keep the other data in these two files in sync when it changes.
|
This pull request is being automatically deployed with Vercel (learn more). |
|
For some reason we do not have recent |
|
We can manually run the deploys for each of these models. I can take care of that tomorrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been challenging to ensure that changes get deployed correctly in
staging because it requires a number of extra steps around tagging,
publishing and updating the
models.ymlfile. The majority of this paincomes from the fact that we were sharing the
models.ymlfile betweenproduction and other environments and therefore couldn't relax our
versioning between environments.
This change copies the existing
models.ymlfile tomodels-staging.ymland changes all of the model/connector image URLsto point at the
mastertag rather than a more specific version tag. Italso adds a switch where this file is loaded by the app to load the
correct version based on the environment. The downside to this approach
is that there will be extra effort and attention needed to keep the
other data in these two files in sync when it changes.